Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

GetLeaderSchedule RPC API can now return a schedule for arbitrary epoches#7542

Merged
mvines merged 1 commit into
solana-labs:masterfrom
mvines:s
Dec 18, 2019
Merged

GetLeaderSchedule RPC API can now return a schedule for arbitrary epoches#7542
mvines merged 1 commit into
solana-labs:masterfrom
mvines:s

Conversation

@mvines
Copy link
Copy Markdown
Contributor

@mvines mvines commented Dec 17, 2019

GetLeaderSchedule returns the current leader schedule but as a client I:

  1. have no guarantees about the actual epoch that schedule was for -- at an epoch boundary I might get confused.
  2. have no way to ask for an older epoch, if the node has that data.

@mvines mvines added the v0.21 label Dec 17, 2019
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 18, 2019

Codecov Report

Merging #7542 into master will decrease coverage by 8.3%.
The diff coverage is 36.5%.

@@           Coverage Diff            @@
##           master   #7542     +/-   ##
========================================
- Coverage      73%   64.7%   -8.4%     
========================================
  Files         244     245      +1     
  Lines       54867   61974   +7107     
========================================
+ Hits        40088   40133     +45     
- Misses      14779   21841   +7062


#### Parameters:

* `slot` - (optional) Fetch the leader schedule for the epoch that corresponds to the provided slot. If unspecified, the leader schedule for the current epoch is fetch
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"fetched"?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I'll scope this up in the follow-up work I'm doing now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants